Add missing address2 details #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When providing an address on the order page, the form has two address fields. However, when you enter details in the second address field (address2) those details are not included in the order confirmation or the order confirmation email. This commit updates both to correctly include the full address details. Note that if we don't check for the existence of address.address2 and shippingAddress.address2 in server/methods/core/orders.js then we'll see undefined for address2 in the contents of the e-mail. Closes reactioncommerce#3601
|
lgtm |
prinzdezibel
previously approved these changes
Feb 10, 2018
There was a problem hiding this comment.
Thank you @mattt416 .
I've verified that it works and the mail format is compliant to common mail format requirements, like that for UPS: https://pe.usps.com/text/pub28/28c2_003.htm
|
Thanks @prinzdezibel ! The ternary in the template feels a bit clumsy, so happy to adjust this if others think it should be moved out. I'll need some guidance though as I'd have no idea where to move it to. :) |
brent-hoover
dismissed
prinzdezibel’s stale review
Only Jeremy should be approving Community PR's
jshimko
approved these changes
Feb 12, 2018
This was referenced Feb 15, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3601
When providing an address on the order page, the form has two address
fields. However, when you enter details in the second address field
(address2) those details are not included in the order confirmation or
the order confirmation email.
This commit updates both to correctly include the full address details.
Note that if we don't check for the existence of address.address2 and
shippingAddress.address2 in server/methods/core/orders.js then we'll
see undefined for address2 in the contents of the e-mail.