Fix #3720: Added space to Taxcloud notice #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use i18nKey to have translation working again - use to have space working for other translations as well.
Fix: Use   to have it working for translations as well.
prinzdezibel
approved these changes
Feb 11, 2018
There was a problem hiding this comment.
Thank you for your contribution, @wackywombaat12 .
Your fix did only target the english default language, but not the translations. Interestingly, the translations itself did also not work, because the attribute was named i18nkey instead of i18nKey.
prinzdezibel
approved these changes
Feb 11, 2018
|
Thanks @prinzdezibel! Apologies for forgetting about the translations. |
|
@prinzdezibel Generally you do not need to correct translations. Our translation service will update other languages based on changes to English. |
|
@zenweasel I didn't correct the translation strings, but the translation
itself was not working, because of a typo in React attribute
Sent from mobile device. Please excuse brevity and typos.
…On Feb 12, 2018 1:56 AM, "Brent Hoover" ***@***.***> wrote:
@prinzdezibel <https://github.com/prinzdezibel> Generally you do not need
to correct translations. Our translation service will update other
languages based on changes to English.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3722 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABpybWuXJ8ctd0COQ31MrGWLlMnEVCUiks5tT4wqgaJpZM4SBKwO>
.
|
jshimko
approved these changes
Feb 12, 2018
This was referenced Feb 15, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for Issue #3720
There is now a space in the message after the word enable.