Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Cart image & Remove cart icon alignment fixes #3740

Merged
merged 5 commits into from
Feb 14, 2018

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Feb 13, 2018

Resolves #3668 | Resolves #3667
Impact: minor
Type: bugfix

Issue

We are seeing some alignment issues on items inside the cart - the item image overlaps the checkout button, and the remove from cart button is also out of place.

Solution

Add correct positioning, via CSS, so that the items are aligned as they should be.

Breaking changes

None

Testing

  1. Add items to the cart
  2. See that the item images do not overlap the checkout button, and that the remove from cart X is in the top right corner

@kieckhafer kieckhafer changed the base branch from master to release-1.8.0 February 13, 2018 19:37
@kieckhafer kieckhafer changed the title Fix 3668 kieckhafer cart alignment issues [WIP] (fix): Cart image & Remove cart icon alignment fixes Feb 13, 2018
@kieckhafer kieckhafer changed the title [WIP] (fix): Cart image & Remove cart icon alignment fixes (fix): Cart image & Remove cart icon alignment fixes Feb 13, 2018
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful 😢

@mikemurray mikemurray merged commit 3d80a81 into release-1.8.0 Feb 14, 2018
@mikemurray mikemurray deleted the fix-3668-kieckhafer-cartAlignmentIssues branch February 14, 2018 22:19
This was referenced Feb 15, 2018
@spencern spencern mentioned this pull request Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants