-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address validation GraphQL #4767
Merged
aldeed
merged 15 commits into
release-2.0.0-rc.7
from
feat-aldeed-address-validation-graphql
Nov 7, 2018
Merged
Address validation GraphQL #4767
aldeed
merged 15 commits into
release-2.0.0-rc.7
from
feat-aldeed-address-validation-graphql
Nov 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldeed
force-pushed
the
feat-aldeed-address-validation-graphql
branch
from
October 24, 2018 03:22
a90fa74
to
f9eb2b3
Compare
I reviewed but cannot approve since I created it. 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #issueNumber
Impact: breaking
Type: feature
Changes
Breaking changes
Breaking changes to how address validation works. Affects all plugins that provide address validation and all clients that validate addresses.
Testing
Example plugin and GQL query
addressValidation
.QUERY:
Registering a custom validation plugin
/imports/plugins/custom/
for a test validation plugin.register.js
andaddressValidation.js
files, restart reactions and log in as an admin.TEST FILES:
Review the docs