-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update graphql packages to support extend enum and extend union #4798
Update graphql packages to support extend enum and extend union #4798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but I don't have time to test the app thoroughly right now. If @zenweasel or @rosshadden can do some minimal smoke tests, I'm down with merging this. We can roll back pretty easily if it leads to issues that aren't easily fixed, and it'll get a thorough test during RC7 release testing.
For some reason I am not able to check out in the StarterKit although I can checkout in the Classic UI. I am getting no shipping methods even though they are configured |
Hi @zenweasel , I think the fulfillment methods are loaded to cart when cart is created and not updated when fulfillment methods are enabled/disabled. So a new cart needs to be created to load the available fulfillment methods into the cart and the UI. I am also unable to make the |
I am getting a ton of new graphql/apollo package dependency warnings. I have done
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran some smoke tests and seems to be fine. There are failing tests though. Also would like to get the npm warnings worked out though I don't think we need to handle that now
I pushed a commit to fix the failing unit tests |
Resolves #4759
Impact: minor
Type: refactor
Issue
We are unable to add custom payment methods without modifying core code as some parts of the schema have to be extended in the plugins. Particularly, we have to use
extend union
andextend enum
in custom plugins, but these graphql specs are not supported in the version ofgraphql
andgraphql-tools
that Reaction currently uses.Solution
Upgrading
graphql
andgraphql-tools
to the respective latest releases enables supportingextend union
andextend enum
.Breaking changes
None
Testing
In the graphql UI, search for
PaymentMethodName
andPaymentData
in the schema docs. See thatPaymentMethodName
includesstripe_card
as an option andStripeCardPaymentData
as possible type.