ECS deployment: move TLS certificate ARN from propel.yaml to ENV vars #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldeed
reviewed
Nov 15, 2018
propel-feat.yaml
Outdated
| port_mappings: | ||
| - container_port: 8082 | ||
| host_port: 8082 | ||
| image: sportsdirect/nginx |
There was a problem hiding this comment.
Is sportsdirect/nginx correct for this repo?
There was a problem hiding this comment.
Good catch, I fixed it.
aldeed
approved these changes
Nov 15, 2018
|
Seems OK as far as I can tell. Just one question, and I'm rerunning app tests that failed. Probably just a random failure. |
|
Failed with during deploy to ecs release branch |
|
Yup looking at it. Looks like AWS user permissions. |
|
I fixed the IAM permissions for the user running propel from CircleCI and the deployment worked. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #issueNumber
Impact: breaking
Type: refactor
Issue
The syntax for the configuration file for the CLI tool propel has been changed so that the TLS Certificate ARN can be specified via an ENV variables and not hardcoded in the configuration file.
Solution
One-line change to the propel.yaml file.
Breaking changes
This is a breaking change in that old propel configuration files will break the deployment process.
Testing
Make sure staging is accessible after a deployment.