-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Put mongo on the streams network #4805
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @focusaurus. Made some change requests that would reduce the scope of change. mongo
service can be added to the streams
network while leaving the internal connections as they were on the default
network.
c708c56
to
80a0010
Compare
80a0010
to
cdb8a0f
Compare
LGTM if @ticean approves of the changes |
May also need to look into why the feature branch deploy step failed on CI. I don't know if deploy will fail when merged in the same way. @griggheo |
@griggheo Looks like errors running propel
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@focusaurus I think you can go ahead and merge if you want, and then I can fix the propel part via another PR.
|
@spencern Do you have admin to merge this despite the CI error? |
Impact: minor
Type: feature
Issue
We are building some data integrations for a separate project and need connectivity to mongo, so putting it on the streams network for local development. This doesn't affect production deployments. The related PR into reaction-platform for the
streams
network is PR 28. It would be best to merge the PR into reaction-platform first then merge this PR.Solution
Put mongo onto the
streams
network, adjust as needed in the config and code. I also removed an additional hard coding inwaitForMongo.js
so more code is properly using theMONGO_URL
environment variable.Breaking changes
This will require the docker network
streams.reaction.localhost
to be created, which developers can do by pulling down the latestreaction-platform
and runningmake
(ormake network-create
if they want to be surgical about it).Testing
waitForMongo.js
as it's normally excludedwaitForMongo.js