Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat env file #4822

Closed
wants to merge 1 commit into from
Closed

Feat env file #4822

wants to merge 1 commit into from

Conversation

rosshadden
Copy link
Contributor

Impact: minor
Type: feature

Description

Added support for a .env file.

Breaking changes

None. All this does is add additional support for a .env file. I did not move the existing variables from docker-compose over to it. I would like to and think we should, but this would mean all users would need to worry about copying/symlinking/creating a .env file so I chose not to make this change here or now.

@rosshadden rosshadden changed the base branch from master to release-2.0.0-rc.7 November 21, 2018 19:06
@aldeed
Copy link
Contributor

aldeed commented Nov 26, 2018

Sorry, @rosshadden I didn't see this until after I did #4826. There was a GH issue for this, which wasn't assigned. Mine makes some additional related changes, so I'll close this one.

@aldeed aldeed closed this Nov 26, 2018
@aldeed aldeed deleted the feat-env-file branch January 24, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants