-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: add home, order, orders, and account profile urls to shop object #5145
ref: add home, order, orders, and account profile urls to shop object #5145
Conversation
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@aldeed @mikemurray this is the non-UI work for #5144. Will do UI next, but separately, so that all the blocked tickets mentioned in #5144 can be moved on. @aldeed also working on separating the four URL's so that they can be independently updated in a GQL query, we can squeeze that in here, or add that in the UI PR. |
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things
imports/plugins/core/core/server/no-meteor/schemas/shop.graphql
Outdated
Show resolved
Hide resolved
imports/plugins/core/core/server/no-meteor/schemas/shop.graphql
Outdated
Show resolved
Hide resolved
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
fixed issues, ready for another look
imports/plugins/core/core/server/no-meteor/mutations/updateShopUrls.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small JSDoc change and otherwise good!!!
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@machikoyasuda updated with changes, ready for another look |
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Resolves #5144 (non-UI parts)
Impact: minor
Type: refactor
Issue
The API does not know what the storefront URLs are, so it can't use proper URLs when generating emails or redirecting after password resets, etc.
Solution
Add the following fields to
Shop
schema. They have been grouped in astorefrontUrls
object onshop
. They are allString
type and optional with no default value:storefrontHomeUrl
storefrontOrderUrl
(can have:orderReferenceId
and:orderToken
in the string)storefrontOrdersUrl
(can have:accountId
in the string)storefrontAccountProfileUrl
(can have:accountId
in the string)Add a new GraphQL mutation,
updateShopUrls
that allows admins to update these new fields.Breaking changes
None
Testing