fix: race condition by awaiting each publish catalog function by type… #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnnnat
commented
Apr 26, 2019
| @@ -252,10 +252,11 @@ export default async function createCatalogProduct(product, context) { | |||
| const catalogProduct = await xformProduct({ collections, product, shop, variants }); | |||
|
|
|||
| // Apply custom transformations from plugins. | |||
| getFunctionsOfType("publishProductToCatalog").forEach((customPublishFunc) => { | |||
| for (const customPublishFn of getFunctionsOfType("publishProductToCatalog")) { | |||
There was a problem hiding this comment.
@aldeed you mentioned writing up a few test for this bug, what should I test for here? I'm looking to make sure each customPublishFn has been called before we return out of this func?
nnnnat
force-pushed
the
fix-nnnnat-awaiting-funcbytype
branch
from
90d2c50
to
19c4e68
Compare
… call. Signed-off-by: Nat Hamilton <info@nathamilton.com>
focusaurus
approved these changes
Apr 26, 2019
3 tasks
|
I'm going to merge this PR and follow up with another PR with test cases #5152. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Impact: critical
Type: bugfix
Issue
publishProductToCatalogfunction by type would be called synchronously, this would cause partial/incomplete Catalog publish if any of the functions by type were trying to do async operations.Solution
Await the custom function by type calls for the
publishProductToCatalogfunction.Breaking changes
N/A
Testing