Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DangerButton and ConfirmButton components #5200

Merged
merged 6 commits into from
Jun 4, 2019

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jun 4, 2019

Impact: minor
Type: feature

Issue

Added three new Button / Chip components that wrap the MUI button, but give us more control of styling. Also added a fontWeightBold option in our MUI theme.

  1. DangerButton, which just provides a red / danger style on top of the existing MUI button, as the provided MUI button does not come with a red / danger style.

  2. DangerChip, which just provides a red / danger style on top of the existing MUI Chip, as the provided MUI Chip does not come with a red / danger style.

  3. ConfirmButton, which provides a button that when clicked, opens a confirmation modal.

Testing

  1. Add the buttons in places. See that they work.

Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@mikemurray mikemurray merged commit 402ee9a into develop Jun 4, 2019
@mikemurray mikemurray deleted the feat-kieckhafer-dangerButton branch June 4, 2019 22:00
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants