Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shop with data error #5207

Merged
merged 2 commits into from
Jun 11, 2019
Merged

fix: shop with data error #5207

merged 2 commits into from
Jun 11, 2019

Conversation

mikemurray
Copy link
Member

Impact: critical
Type: bugfix

Issue

data was sometimes undefined in the ShopLogoWithData component causing the app to crash

Solution

  1. Add an error boundary component
  2. Check for data before trying to access

Breaking changes

none

Testing

  1. Run the app, make sure it still works and that shop logo shows up in various places

@mikemurray
feat: add generic error boundary component
4b53b9a 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
fix: guard query, and check for data before accessing it
d0bae7c 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray mikemurray changed the title Fix mikemurray shop with data fix: shop with data error Jun 11, 2019
@mikemurray mikemurray merged commit 1295041 into develop Jun 11, 2019
@mikemurray mikemurray deleted the fix-mikemurray-shop-with-data branch June 11, 2019 17:09
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosshadden rosshadden rosshadden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemurray @rosshadden