Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app will not start #5216

Merged
merged 1 commit into from
Jun 18, 2019
Merged

fix: app will not start #5216

merged 1 commit into from
Jun 18, 2019

Conversation

mikemurray
Copy link
Member

Impact: critical
Type: bugfix

Issue

The app will not start due to an error in the addRolesToGroups function in /imports/plugins/core/accounts/server/no-meteor/util/addRolesToGroups.js:51

Solution

Pass context to addRolesToGroupAndUsers()

Breaking changes

none

Testing

  1. start the app
  2. ensure that startup is successful and you can sign in to the operator panel
  3. use the app and ensure it functions as expected

@mikemurray
fix: pass context as first param
249011c 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
kieckhafer
kieckhafer approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, fixes the issue we were experiencing.

@kieckhafer kieckhafer merged commit 22bd646 into develop Jun 18, 2019
@kieckhafer kieckhafer deleted the fix-mikemurray-app-startup-accounts branch June 18, 2019 04:13
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieckhafer kieckhafer kieckhafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemurray @kieckhafer