feat: add shopLogoUrls to shop settings to allow logo to be rendered from url #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
kieckhafer
changed the title
aldeed
reviewed
Jun 20, 2019
| } | ||
| }); | ||
|
|
||
| registerSchema("ShopLogoUrls", ShopLogoUrls); |
There was a problem hiding this comment.
I don't see this being used anywhere. Should the field just be added to shop schema?
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
kieckhafer
changed the title
Signed-off-by: Erik Kieckhafer <ek@ato.la>
|
|
|
@kieckhafer merging develop into this branch should fix the build issues. |
…dShopLogoUrlField
aldeed
approved these changes
Jun 28, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature
Adds a field to allow operators to link to an existing logo URL, and use that logo / url as their primary shop logo.
Breaking changes
None. The URL logo will take precedence, if available, but will not affect anything if it is not added.
Testing