Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetical currencies #5230

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Alphabetical currencies #5230

merged 3 commits into from
Jun 21, 2019

Conversation

chrispotter
Copy link

@chrispotter chrispotter commented Jun 21, 2019

Resolves #4757
Impact: minor*
Type: bugfix

Issue

Sorts Currencies Alphabetically in Operator UI

Solution

this.props.currencies.sort((a, b) => a.name.localeCompare(b.name)).map(...

Breaking changes

None

Testing

  1. http://localhost:3000/operator/localization
  2. See that currencies are in order

Chris Potter added 2 commits June 21, 2019 09:50
Signed-off-by: Chris Potter <chris@reactioncommerce.com>
Signed-off-by: Chris Potter <chris@reactioncommerce.com>
Signed-off-by: Chris Potter <chris@reactioncommerce.com>
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kieckhafer kieckhafer merged commit 86a0757 into develop Jun 21, 2019
@kieckhafer kieckhafer deleted the alphabetical_currencies branch June 21, 2019 17:48
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants