feat: authentication plugin; drop support for meteor-login-token header #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authorization header handling remains the same but is moved from accounts plugin to new authentication plugin. meteor-login-token header is no longer used to identify the user Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
aldeed
changed the title
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
mikemurray
approved these changes
Jan 14, 2020
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5998
Impact: major
Type: feature
NOTE: Do not merge until reactioncommerce/reaction-admin#171 has been merged!
Changes
accountsplugin to a newauthenticationplugin.Breaking changes
"meteor-login-token" header is no longer supported. This breaks all releases of Reaction Admin prior to this PR
Testing