refactor: use functionsOfType to register multiple auth permissions functions

src/core/util/buildContext.js

@@ -25,8 +25,20 @@ export default async function buildContext(context, request = {}) {
 
   // authorization methods
   if (userId) {
-    if (typeof context.auth.getHasPermissionFunctionForUser === "function") {
-      context.userHasPermission = await context.auth.getHasPermissionFunctionForUser(context);
+    if (context.getFunctionsOfType("getHasPermissionFunctionForUser") && context.getFunctionsOfType("getHasPermissionFunctionForUser").length) {
+      context.userHasPermission = async (...args) => {
+        // get all functions of type getHasPermissionFunctionForUser
+        const allAuthPluginFunctions = await context.getFunctionsOfType("getHasPermissionFunctionForUser");
+
+        const allPermissions = await Promise.all(allAuthPluginFunctions.map(async (func) => {
+          // call with context for currying
+          const result = await func(context)(...args);
+          return result;
+        }));
+
+        // userHasPermission if ALL permission checks are `true`
+        return allPermissions.every((permission) => permission === true);
+      };
     } else {
       context.userHasPermission = () => false;
     }

src/core/util/buildContext.test.js

@@ -6,19 +6,19 @@ const mockAccount = { _id: "accountId", userId: fakeUser._id };
 const accountByUserId = jest.fn().mockName("accountByUserId").mockReturnValue(Promise.resolve(mockAccount));
 
 const auth = {
-  accountByUserId,
-  getHasPermissionFunctionForUserLegacy: () => () => {}
+  accountByUserId
 };
 
 test("properly mutates the context object without user", async () => {
   process.env.ROOT_URL = "http://localhost:3000";
   const context = {
     auth,
-    validatePermissions: mockContext.validatePermissions,
     collections: mockContext.collections,
+    getFunctionsOfType: mockContext.getFunctionsOfType,
     queries: {
       primaryShopId: () => "PRIMARY_SHOP_ID"
-    }
+    },
+    validatePermissions: mockContext.validatePermissions
   };
 
   await buildContext(context, { user: undefined });
@@ -27,6 +27,7 @@ test("properly mutates the context object without user", async () => {
     accountId: null,
     auth,
     collections: mockContext.collections,
+    getFunctionsOfType: mockContext.getFunctionsOfType,
     isInternalCall: false,
     queries: {
       primaryShopId: jasmine.any(Function)
@@ -45,18 +46,20 @@ test("properly mutates the context object with user", async () => {
 
   const context = {
     auth,
-    validatePermissions: mockContext.validatePermissions,
     collections: mockContext.collections,
+    getFunctionsOfType: mockContext.getFunctionsOfType,
     queries: {
       primaryShopId: () => "PRIMARY_SHOP_ID"
-    }
+    },
+    validatePermissions: mockContext.validatePermissions
   };
   await buildContext(context, { user: fakeUser });
   expect(context).toEqual({
     account: mockAccount,
     accountId: mockAccount._id,
     auth,
     collections: mockContext.collections,
+    getFunctionsOfType: mockContext.getFunctionsOfType,
     isInternalCall: false,
     queries: {
       primaryShopId: jasmine.any(Function)

src/plugins/legacy-authorization/index.js

@@ -10,8 +10,8 @@ export default async function register(app) {
     label: "Legacy Authorization",
     name: "reaction-legacy-authorization",
     version: app.context.appVersion,
-    auth: {
-      getHasPermissionFunctionForUser
+    functionsByType: {
+      getHasPermissionFunctionForUser: [getHasPermissionFunctionForUser]
     }
   });
 }

src/plugins/legacy-authorization/util/hasPermission.js

@@ -67,7 +67,7 @@ export default async function hasPermission(context, resource, action, authConte
   return false;
 }
 
-const hasPermissionCurried = curryN(2, hasPermission);
+const hasPermissionCurried = curryN(4, hasPermission);
 
 /**
  * @summary Get a `hasPermission` function bound to the current user context