Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5770
Impact: minor
Type: feature
Changes
The project now runs on Node 12.14.1 both for development and for future production builds. This is an LTS version.
Breaking changes
This version of Node requires the new
--experimental-json-modules
flag to run because weimport
JSON files from many ES modules. This is handled already in thepackage.json
scripts but if you are doing something non-standard, you may need to add this flag yourself.Testing
In general you should test 3 variations:
Case 1:
docker-compose up -d
with thedocker-compose.override.yml
file should just workCase 2:
docker-compose down docker build . -t test-api docker-compose up -d mongo docker run --env-file ./.env -p 3000:3000 --network streams.reaction.localhost -it test-api:latest
The
docker build
command should not have any errors and the API should start in production mode without any errors.Case 3:
To test
docker-compose up -d
without thedocker-compose.override.yml
file, you will need to temporarily change theapi.image
value indocker-compose.yml
toreactioncommerce/reaction:feat-aldeed-node-12.14.1