Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updateSurcharge returns the entire document from db #6576

Merged

Conversation

sushmitha-malae
Copy link
Contributor

@sushmitha-malae sushmitha-malae commented Oct 19, 2022

Signed-off-by: Sushmitha Malae malaesushmitha@gmail.com

Resolves #6508
Impact: minor
Type: bugfix

Issue

The updateSurcharge Mutation will only return the updated fields instead of returning the full item from db

Solution

Returning the updated full document instead of the partially updated fields.

Breaking changes

None

Testing

Modified the existing utc, to test the change.

More detail for what each of these sections should include are available in our Contributing Docs. This project uses semantic-release, please use their commit message format..

Signed-off-by: m_sushmitha <m_sushmitha@intuit.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2022

🦋 Changeset detected

Latest commit: fab2907

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@reactioncommerce/api-plugin-surcharges Patch
reaction Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sushmitha-malae
Copy link
Contributor Author

@delagroove Please review the changes, Thanks!

@delagroove
Copy link
Contributor

I'm a bit busy today but if @vannguyenn @vanpho93 @sujithvn can go ahead and review that would work as well!

@brent-hoover brent-hoover requested review from brent-hoover and removed request for sujithvn and vannguyenn October 19, 2022 22:08
@sushmitha-malae
Copy link
Contributor Author

@zenweasel do you have some time for the review?

@brent-hoover brent-hoover merged commit 1bd735b into reactioncommerce:trunk Oct 21, 2022
@github-actions github-actions bot mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updateSurcharge should return the full item from db
3 participants