fix: allow restrictions on nested properties #6578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6501
Impact: minor
Type: bugfix
Issue
The checks for shipping restrictions based on an item's properties only work top for level properties in the item. It doesn't work for nested properties such as
price.amount
orsubtotal.amount
.Steps to reproduce:
price.amount
which would exclude the shipping method for the product if it was applied.price
value).Solution
Can be solved by using lodash
_.get()
for getting the nested property from the item, instead of using the default javascript getter. This would make sure the restrictions work with both nested and non-nested attributes.Testing
weight
which would exclude the shipping method for the product if it was applied.price.amount
which would exclude the shipping method for the product if it was applied.