Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add replaceOne to mockCollection #6592

Conversation

tuanvu0995
Copy link
Contributor

Signed-off-by: tuanvu0995 tuanvu0995@gmail.com

Resolves #6510
Impact: minor
Type: feature

Issue

The replaceOne function that's been available since 3.2 but is not available on Mock collections

Solution

Add the replaceOne mock function to the mockCollection on the api-utils package.

Breaking changes

None

Testing

None

tuanvu0995 and others added 3 commits October 24, 2022 17:20
Signed-off-by: tuanvu0995 <tuanvu0995@gmail.com>
Signed-off-by: tuanvu0995 <tuanvu0995@gmail.com>
Signed-off-by: tuanvu0995 <tuanvu0995@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: 8854252

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@reactioncommerce/api-utils Minor
reaction Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tuanvu0995 tuanvu0995 force-pushed the feat/add-replaceOne-to-mockCollection branch from 55d2274 to 6a7d8be Compare October 25, 2022 01:46
Signed-off-by: tuanvu0995 <tuanvu0995@gmail.com>
@tuanvu0995 tuanvu0995 force-pushed the feat/add-replaceOne-to-mockCollection branch from 6a7d8be to 8854252 Compare October 25, 2022 01:48
@brent-hoover brent-hoover self-requested a review October 25, 2022 03:33
@brent-hoover brent-hoover merged commit 95bc16a into reactioncommerce:trunk Oct 25, 2022
@github-actions github-actions bot mentioned this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add replaceOne to mockCollection
2 participants