Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint linter complained again #94

Closed
2 tasks done
reactive-firewall opened this issue Sep 12, 2024 · 2 comments · Fixed by #95 or #127
Closed
2 tasks done

pylint linter complained again #94

reactive-firewall opened this issue Sep 12, 2024 · 2 comments · Fixed by #95 or #127
Assignees
@reactive-firewall
Labels
enhancement New feature or request Linter Any linter tool or setting file enhancements Python Lang Changes to Python source code
Milestone
OOP Refactor

Comments

@reactive-firewall
Copy link
Owner

PYL-C0201

Deepsource linter found PYL-C0201:

Basic Info

When reporting an issue, please list the version of Python Multicast Library you are using and any relevant information about your software environment:

  • Python version:
    • 3.0+ (including 3.0 thru 3.12)
  • OS type

uname -a

  • linux
  • MacOS (darwin)
  • multicast version:

python3 -m multicast --version
1.4.6-dev

Additional Information:

DESCRIPTION
Consider iterating the dictionary directly instead of calling .keys(). Using for key in dictionary would always iterate the dictionary keys.
@reactive-firewall reactive-firewall added enhancement New feature or request Linter Any linter tool or setting file enhancements Python Lang Changes to Python source code labels Sep 12, 2024
@reactive-firewall reactive-firewall self-assigned this Sep 12, 2024
@reactive-firewall
Copy link
Owner Author

ℹ️ The in and not in syntax and realation to dict.keys() is explained well by realpython.com

reactive-firewall added a commit that referenced this issue Sep 12, 2024
@reactive-firewall
[STYLE] attempt to improve code quality (- WIP #94 -)
24128f1 
### ChangeLog:

Changes in file multicast/__main__.py:
 class McastRecvHearDispatch(mtool):
 def NoOp(*args, **kwargs):
 def setupArgs(cls, parser):

Changes in file multicast/hear.py:
 class McastHEAR(multicast.mtool):

Changes in file multicast/recv.py:
 def _hearstep(self, groups, port, iface=None, bind_group=None):

Changes in file multicast/send.py:
 def _sayStep(self, group, port, data):
@reactive-firewall reactive-firewall mentioned this issue Sep 12, 2024
Closed
26 tasks
reactive-firewall added a commit that referenced this issue Sep 13, 2024
@reactive-firewall
[STYLE] Suppress pylint by fix or rule but suppress (- WIP #94 -)
2d3013f 
### ChangeLog:

Changes in file .coveragerc:
 exclude_lines =

Changes in file multicast/__init__.py:
 Unknown Changes

Changes in file multicast/__main__.py:
 def useTool(self, tool, **kwargs):

Changes in file multicast/hear.py:
 Unknown Changes

Changes in file multicast/recv.py:
 Unknown Changes

Changes in file multicast/send.py:
 def _sayStep(self, group, port, data):

Changes in file multicast/skt.py:
 Unknown Changes

Changes in file tests/context.py:
 Unknown Changes

Changes in file tests/test_usage.py:
 def test_aborts_WHEN_calling_multicast_GIVEN_invalid_tools(self):
reactive-firewall added a commit that referenced this issue Sep 13, 2024
@reactive-firewall
[STYLE] possible fix for PYL-R0123 (- WIP #94 -)
e470470 
### ChangeLog:

Changes in file tests/context.py:
 def checkPythonCommand(args, stderr=None):
 def timePythonCommand(args=[None], stderr=None):
reactive-firewall added a commit that referenced this issue Sep 13, 2024
@reactive-firewall
[STYLE] Minor updates to _sayStep core function (- WIP #94 -)
cdf4f9d 
### ChangeLog:

Changes in file multicast/send.py:
 def setupArgs(cls, parser):
reactive-firewall added a commit that referenced this issue Sep 13, 2024
@reactive-firewall
[STYLE] Minor updates to internal module structures to improve perfor…
aaa51db 
…mance (- WIP #94 -)

### ChangeLog:

Changes in file multicast/__init__.py:
 Unknown Changes

Changes in file multicast/__main__.py:
 class McastDispatch(mtool):
 class McastNope(mtool):
 def setupArgs(cls, parser):

Changes in file multicast/recv.py:
 def _hearstep(self, groups, port, iface=None, bind_group=None):
 def setupArgs(cls, parser):

Changes in file tests/MulticastUDPClient.py:
 Unknown Changes
@reactive-firewall reactive-firewall added this to the OOP Refactor milestone Sep 13, 2024
@reactive-firewall reactive-firewall linked a pull request Sep 13, 2024 that will close this issue
Pylint linter fixes #95
Merged
reactive-firewall added a commit that referenced this issue Sep 13, 2024
@reactive-firewall
[PATCH] Suppress pylint by fix or rule but suppress (- WIP #94 -)
e2eff3e 
### ChangeLog:

Changes in file multicast/__main__.py:
 Unknown Changes

Changes in file multicast/hear.py:
 Unknown Changes

Changes in file multicast/recv.py:
 Unknown Changes

Changes in file multicast/send.py:
 Unknown Changes

Changes in file multicast/skt.py:
 Unknown Changes
reactive-firewall added a commit that referenced this issue Sep 13, 2024
@reactive-firewall
[MERGE]
e760262 
* from PR #97 (HOTFIX-deps-style-update):
  [DOCUMENTATION] minor update for 'build' module license details (- WIP #96 & #80 -)
  [DOCUMENTATION] minor update for flake8 license details (- WIP #96 & #80 -)
  [DOCUMENTATION] minor update for tox license details (- WIP #96 & #80 -)

* from PR #95 (pylint-linter-fixes):
  Update multicast/__main__.py as suggested
  [PATCH] Suppress pylint by fix or rule but suppress (- WIP #94 -)
  [STYLE] Minor updates to internal module structures to improve performance (- WIP #94 -)
  [STYLE] Minor updates to _sayStep core function  (- WIP #94 -)
  [STYLE] possible fix for PYL-R0123 (- WIP #94 -)
  [STYLE] Suppress pylint by fix or rule but suppress (- WIP #94 -)
  [STYLE] attempt to improve code quality (- WIP #94 -)
@reactive-firewall reactive-firewall mentioned this issue Sep 19, 2024
Merged
reactive-firewall added a commit that referenced this issue Sep 25, 2024
@reactive-firewall
[DOCUMENTATION] adding lots of extra comments to subdue deepsource's …
a054d2c 
…overlooking its own config (- WIP #94 -)

Changes in file multicast/__init__.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file multicast/__main__.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file multicast/hear.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file multicast/recv.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file multicast/send.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file tests/MulticastUDPClient.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file tests/__init__.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file tests/check_cc_lines:
 - workaround for over zelous skip reporting when only skips, ignores,
   and-or passes for previous checked files.

Changes in file tests/context.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file tests/profiling.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file tests/test_basic.py:
 - added more skipcq to muzzle false positives from deepsource 🙉

Changes in file tests/test_usage.py:
 - added more skipcq to muzzle false positives from deepsource 🙉
reactive-firewall added a commit that referenced this issue Sep 25, 2024
@reactive-firewall
[STYLE] Fix for possible FLK-W293 (- WIP #94 -)
22d09aa 
Changes in file multicast/hear.py:
 - also added some trivial doctests (- WIP #79 -)
reactive-firewall added a commit that referenced this issue Sep 25, 2024
@reactive-firewall
[PATCH] Fixups for deepsource antics and GHA CI config (- WIP #94 & PR …
3bc26f2 
…#118 -)

Changes in file .github/workflows/Tests.yml:
 - cleaning up some regressions (- PR #118 -)

Changes in file multicast/hear.py:
 - more workarounds for deepsource defective config

Changes in file multicast/recv.py:
 - more workarounds for deepsource defective config

Changes in file multicast/send.py:
 - more workarounds for deepsource defective config

Changes in file tests/MulticastUDPClient.py:
 - more workarounds for deepsource defective config
@reactive-firewall reactive-firewall mentioned this issue Sep 25, 2024
Merged
6 tasks
@reactive-firewall
Copy link
Owner Author

Possible fix

reactive-firewall added a commit that referenced this issue Sep 25, 2024
@reactive-firewall
[REGRESSION] Deepsource F**ed up again and went on the flake (- WIP #94…
05229e8 
… -)

Changes in file multicast/hear.py:
 - possible workaround added

Changes in file multicast/recv.py:
 - possible workaround added

Changes in file tests/test_usage.py:
 - possible workaround added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reactive-firewall reactive-firewall

Labels
enhancement New feature or request Linter Any linter tool or setting file enhancements Python Lang Changes to Python source code
Projects
Multicast Project
Archived in project
Milestone
OOP Refactor
1 participant
@reactive-firewall