Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repository structure #1251

Merged

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jan 20, 2025

Description

ReactPy was switched to a monorepo structure a while back. This change unfortunately over-complicated the toolchain, CI, and project structure to the point where it was unmaintainable.

This PR refactors large parts of the repository to make ReactPy easier to maintain. Since the LOC changes in this PR started getting out of hand, a follow up PR will be needed to standardize the repo structure to perfectly match our other repos.

Changelog

  • Refactor repo away from monorepo structure into something more standard/maintainable
  • Replace react usage with preact/compat within @reactpy/client.
    • This was previously being done via build-time name substitutions, but realistically ReactPy is the only user of @reactpy/client, so we may as well "clean up" the build path for ourselves.
  • Remove tests for module_from_template due to unfixable failures

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@Archmonger Archmonger changed the title V1.2-refactor-repo-structure Refactor repository structure Jan 20, 2025
@Archmonger Archmonger marked this pull request as ready for review January 21, 2025 08:32
@Archmonger Archmonger merged commit 90c25e0 into reactive-python:main Jan 21, 2025
17 checks passed
@Archmonger Archmonger deleted the v1.2-refactor-repo-structure branch January 21, 2025 08:37
This was referenced Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant