Create separate use_async_effect
hook
#1264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ReactPy is made to mimick ReactJS as close to 1:1 as possible.
However, despite this we have support for async effects. Additionally, async effects bring their own technical challenges, especially related to effect cancellation.
This PR forces
use_effect
to only exist for synchronous functions, and creates a separateuse_async_effect
function. This allowsuse_effect
to better align with the ReactJS equivalent, and subsequently allowuse_async_effect
to accept additional arguments that deviate from ReactJS. For example, in the future we may add atimeout
value touse_effect
.Tangentially related issues:
use_effect
calls #1136Follow-up PR:
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).