Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

467: fixes method names in white/black box testing of Flow.Subscriber #468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CopyrightWaivers.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,6 @@ jroper | James Roper, james@jazzy.id.au, Lightbend Inc.
olegdokuka | Oleh Dokuka, shadowgun@.i.ua, Netifi Inc.
Scottmitch | Scott Mitchell, scott_mitchell@apple.com, Apple Inc.
retronym | Jason Zaugg, jzaugg@gmail.com, Lightbend Inc.
lucav76 | Luca Venturi, lventuri76@gmail.com
sullis | Sean Sullivan, github@seansullivan.com

4 changes: 2 additions & 2 deletions tck-flow/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ public class MyFlowSubscriberWhiteboxVerificationTest extends FlowSubscriberWhit
// class SyncSubscriber<T> extends Flow.Subscriber<T> { /* ... */ }

@Override
public Flow.Subscriber<Integer> createSubscriber(final WhiteboxSubscriberProbe<Integer> probe) {
public Flow.Subscriber<Integer> createFlowSubscriber(final WhiteboxSubscriberProbe<Integer> probe) {
// in order to test the SyncSubscriber we must instrument it by extending it,
// and calling the WhiteboxSubscriberProbe in all of the Subscribers methods:
return new SyncSubscriber<Integer>() {
Expand Down Expand Up @@ -402,7 +402,7 @@ public class MyFlowSubscriberBlackboxVerificationTest extends FlowSubscriberBlac
}

@Override
public Flow.Subscriber<Integer> createSubscriber() {
public Flow.Subscriber<Integer> createFlowSubscriber() {
return new MySubscriber<Integer>();
}

Expand Down