Skip to content

Commit

Permalink
Fix transport tests when using zookeeper
Browse files Browse the repository at this point in the history
  • Loading branch information
lucifer4j committed Aug 8, 2023
1 parent 3e93f98 commit c1937b7
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 17 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.apache.pinot.client.ResultSetGroup;
import org.apache.pinot.client.VertxPinotClientTransport;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.testcontainers.containers.GenericContainer;
Expand All @@ -47,7 +46,7 @@ public class VertxConnectionTest {
@Container
public static GenericContainer<?> pinot = new GenericContainer<>(DockerImageName.parse("apachepinot/pinot:0.12.0"))
.withCommand("QuickStart -type batch")
.withExposedPorts(2181, 8000, 9000)
.withExposedPorts(2123, 8000, 9000)
.waitingFor(Wait.forLogMessage(".*Offline quickstart setup complete.*\\n", 1))
.withStartupTimeout(Duration.ofSeconds(600))
.withReuse(true);
Expand Down Expand Up @@ -129,9 +128,8 @@ public void testVertxTransportWithController(VertxTestContext testContext) {
}

@Test
@Disabled
public void testVertxTransportWithZookeeper(VertxTestContext testContext) {
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2181) + "/QuickStartCluster";
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2123) + "/QuickStartCluster";
VertxPinotClientTransport transport = new VertxPinotClientTransport(vertx.getDelegate());
VertxConnection connection = VertxConnectionFactory.fromZookeeper(vertx, zookeeperUrl, transport);
executeQueryTest(testContext, connection);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.apache.pinot.client.ResultSetGroup;
import org.apache.pinot.client.VertxPinotClientTransport;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.testcontainers.containers.GenericContainer;
Expand All @@ -47,7 +46,7 @@ public class VertxConnectionTest {
@Container
public static GenericContainer<?> pinot = new GenericContainer<>(DockerImageName.parse("apachepinot/pinot:0.12.0"))
.withCommand("QuickStart -type batch")
.withExposedPorts(2181, 8000, 9000)
.withExposedPorts(2123, 8000, 9000)
.waitingFor(Wait.forLogMessage(".*Offline quickstart setup complete.*\\n", 1))
.withStartupTimeout(Duration.ofSeconds(600))
.withReuse(true);
Expand Down Expand Up @@ -127,9 +126,8 @@ public void testVertxTransportWithController(VertxTestContext testContext) {
}

@Test
@Disabled
public void testVertxTransportWithZookeeper(VertxTestContext testContext) {
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2181) + "/QuickStartCluster";
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2123) + "/QuickStartCluster";
VertxPinotClientTransport transport = new VertxPinotClientTransport(vertx.getDelegate());
VertxConnection connection = VertxConnectionFactory.fromZookeeper(vertx, zookeeperUrl, transport);
executeQueryTest(testContext, connection);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.apache.pinot.client.ResultSetGroup;
import org.apache.pinot.client.VertxPinotClientTransport;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.testcontainers.containers.GenericContainer;
Expand All @@ -47,7 +46,7 @@ public class VertxConnectionTest {
@Container
public static GenericContainer<?> pinot = new GenericContainer<>(DockerImageName.parse("apachepinot/pinot:0.12.0"))
.withCommand("QuickStart -type batch")
.withExposedPorts(2181, 8000, 9000)
.withExposedPorts(2123, 8000, 9000)
.waitingFor(Wait.forLogMessage(".*Offline quickstart setup complete.*\\n", 1))
.withStartupTimeout(Duration.ofSeconds(600))
.withReuse(true);
Expand Down Expand Up @@ -127,9 +126,8 @@ public void testVertxTransportWithController(VertxTestContext testContext) {
}

@Test
@Disabled
public void testVertxTransportWithZookeeper(VertxTestContext testContext) {
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2181) + "/QuickStartCluster";
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2123) + "/QuickStartCluster";
VertxPinotClientTransport transport = new VertxPinotClientTransport(vertx.getDelegate());
VertxConnection connection = VertxConnectionFactory.fromZookeeper(vertx, zookeeperUrl, transport);
executeQueryTest(testContext, connection);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.apache.pinot.client.ResultSetGroup;
import org.apache.pinot.client.VertxPinotClientTransport;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.testcontainers.containers.GenericContainer;
Expand All @@ -47,7 +46,7 @@ public class VertxConnectionTest {
@Container
public static GenericContainer<?> pinot = new GenericContainer<>(DockerImageName.parse("apachepinot/pinot:0.12.0"))
.withCommand("QuickStart -type batch")
.withExposedPorts(2181, 8000, 9000)
.withExposedPorts(2123, 8000, 9000)
.waitingFor(Wait.forLogMessage(".*Offline quickstart setup complete.*\\n", 1))
.withStartupTimeout(Duration.ofSeconds(600))
.withReuse(true);
Expand Down Expand Up @@ -123,12 +122,11 @@ public void testVertxTransportWithController(VertxTestContext testContext) {
}

@Test
@Disabled
public void testVertxTransportWithZookeeper(VertxTestContext testContext) {
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2181) + "/QuickStartCluster";
String zookeeperUrl = "localhost:" + pinot.getMappedPort(2123) + "/QuickStartCluster";
VertxPinotClientTransport transport = new VertxPinotClientTransport(vertx);
VertxConnection connection = VertxConnectionFactory.fromZookeeper(vertx, zookeeperUrl, transport);
executeQueryTest(testContext, connection);
}

}
}

0 comments on commit c1937b7

Please sign in to comment.