Support Binding to IReactiveObject's #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently, ReactiveUI.Validation doesn't support creating
ValidationRule
s for objects that don't inherit from aReactiveObject
. Also, binding toIViewFor<IReactiveObject>
viaBindValidation
isn't supported. However, there may be cases, when one needs to use an interface as a type parameter inIViewFor
(e.g.IViewFor<IViewModel>
). Also, some folks may decide to use a customIReactiveObject
implementation e.g. in case if they use ReactiveUI with MvvmCross, Prism, etc. So this PR changes the generic type constraint from: ReactiveObject
to: class, IReactiveObject
and adds a few tests for this.What is the current behavior?
Currently, ReactiveUI.Validation doesn't support binding to
IReactiveObject
s.What is the new behavior?
Now, ReactiveUI.Validation supports binding to
IReactiveObject
s.What might this PR break?
Nothing.