Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Update the Documentation and Code Snippets in README #121

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

worldbeater
Copy link
Collaborator

What kind of change does this PR introduce?

This PR updates README.md with additional notes regarding up-to-date ReactiveUI.Validation features. This PR documents the changes introduced in #119 and #118, including the API changes and new ValidationRule overloads.

What is the current behavior?

Currently, the docs in README.md are a bit outdated.

What is the new behavior?

Now, the docs in README.md should be up-to-date.

What might this PR break?

Nothing. However, we may need to publish a new release for our NuGet to match the documentation.

@worldbeater worldbeater marked this pull request as ready for review October 14, 2020 13:22
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #121 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   60.33%   60.33%           
=======================================
  Files          15       15           
  Lines         837      837           
=======================================
  Hits          505      505           
  Misses        332      332           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d87bc...c23110c. Read the comment docs.

@glennawatson glennawatson merged commit 7a38594 into main Oct 14, 2020
@glennawatson glennawatson deleted the wb-documentation-update branch October 14, 2020 15:25
@reactiveui reactiveui locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants