housekeeping: Add Analyzers to the Sample App #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR adds analyzers to our
LoginApp
which is our sample app. Also, this PR fixes the warnings produced by the analyzers. Additionally, we are now referencingReactiveUI.Validation
as<PackageReference Include="ReactiveUI.Validation" Version="1.8.*" />
, this should allow folks to run the sample app without the need to install dozens of frameworks and libraries, so this should make the samples more accessible. Finally, this adds anIUserDialogs
implementation to our newLoginApp.Android
project introduced in #138What is the current behavior?
Currently, there are no analyzers in our sample
LoginApp
.What is the new behavior?
Now, the
analyzers
are added.What might this PR break?
Nothing.