Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Add Analyzers to the Sample App #143

Merged
merged 11 commits into from
Oct 19, 2020
Merged

Conversation

worldbeater
Copy link
Collaborator

What kind of change does this PR introduce?

This PR adds analyzers to our LoginApp which is our sample app. Also, this PR fixes the warnings produced by the analyzers. Additionally, we are now referencing ReactiveUI.Validation as <PackageReference Include="ReactiveUI.Validation" Version="1.8.*" />, this should allow folks to run the sample app without the need to install dozens of frameworks and libraries, so this should make the samples more accessible. Finally, this adds an IUserDialogs implementation to our new LoginApp.Android project introduced in #138

What is the current behavior?

Currently, there are no analyzers in our sample LoginApp.

What is the new behavior?

Now, the analyzers are added.

What might this PR break?

Nothing.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #143 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   61.57%   61.57%           
=======================================
  Files          16       16           
  Lines         877      877           
=======================================
  Hits          540      540           
  Misses        337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ad58c...6edbf52. Read the comment docs.

@worldbeater worldbeater merged commit e7bc86d into main Oct 19, 2020
@worldbeater worldbeater deleted the sample-analyzers branch October 19, 2020 19:19
@reactiveui reactiveui locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant