Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping: Update MSBuild.Sdk.Extras #53

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

mallibone
Copy link
Contributor

Build fails due to .Net Core SDK which is no longer available on hosted agent. Aligned this file with other JSONs from the Reactive UI family.

What kind of change does this PR introduce?
Removes SDK definition
Updates MSBuild.SDK.Extras version

What is the current behavior?
The build is failing on the agent.

What is the new behavior?
The build should work again.

What might this PR break?
The build may still be broken after this.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Build fails due to .Net Core SDK which is no longer available on hosted agent. Aligned this file with other jsons from the Reactive UI family.
@mallibone mallibone requested a review from a team December 26, 2019 09:51
@glennawatson
Copy link
Collaborator

Thanks for the fixup.

@glennawatson glennawatson changed the title Housekeeping Housekeeping: Update MSBuild.Sdk.Extras Dec 26, 2019
@glennawatson glennawatson merged commit 6603d3d into reactiveui:master Dec 26, 2019
@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants