Fix #60, #61, #70 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 38.66% 42.18% +3.52%
==========================================
Files 18 19 +1
Lines 763 768 +5
Branches 104 104
==========================================
+ Hits 295 324 +29
+ Misses 456 434 -22
+ Partials 12 10 -2
Continue to review full report at Codecov.
|
|
Do you mind bumping to API generator nuget to latest while here too. Will take care of other outstanding pr |
Bumps [PublicApiGenerator](https://github.com/PublicApiGenerator/PublicApiGenerator) from 10.1.0 to 10.2.0. - [Release notes](https://github.com/PublicApiGenerator/PublicApiGenerator/releases) - [Commits](PublicApiGenerator/PublicApiGenerator@10.1.0...10.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
|
Done upgrading the generator! (#81) |
glennawatson
approved these changes
Jul 17, 2020
This was referenced Jul 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
In this PR, the fixes described in #60 and #61 were implemented, as well as the test cases for them. Huge thanks to @ins0mniaque for providing these high-quality bug reports and solutions. Also, an extra
.ObserveOn()added tothis.IsValid()extension method implementation should resolve #70 (for 100% resolution this PR addresses #31 as well)In addition, with this PR we start using
IEnumerable<IValidationComponent>inBindValidationinstead of aReadOnlyObservableCollection, based on the information provided in #31 (comment). This should finally resolve the issues withISchedulers described in #31What might this PR break?
Hopefully nothing.