Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

househeeping: resolve broken CI infrastructure #1587

Merged
merged 35 commits into from
Apr 24, 2018
Merged

househeeping: resolve broken CI infrastructure #1587

merged 35 commits into from
Apr 24, 2018

Conversation

ghuntley
Copy link
Member

@ghuntley ghuntley commented Apr 4, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Housekeeping

What is the current behavior? (You can also link to an open issue here)

Our build is currently broken

What is the new behavior (if this is a feature change)?

Moves all of our pinned dependencies to a consistent version so that we may fix GitVersion. After this PR is merged the build will be green and we can proceed with motions of release.

What might this PR break?

Nothing but we will be unable to test the release workflow until develop is merged into master.

Other information:

These tasks are outstanding before this PR can be merged

  • Upgrade Cake.FileHelpers to Cake.Core 0.22.0 (inc PR'ing upstream ecosystem if needed

  • Upgrade Cake.Coveralls to Cake.Core 0.22.0 (inc PR'ing upstream ecosystem if needed

  • Upgrade Cake.PinNuGetDependency to Cake.Core 0.22.0 (inc PR'ing upstream ecosystem if needed

  • Upgrade Cake.Powershell to to Cake.Core 0.22.0 (inc PR'ing upstream ecosystem if needed

  • Resolve GitVersion errors (run cake at diagnostic logging to see specifics of the GitVersion stacktrace.)

  • Upgrade these if needed:

#tool "nuget:?package=GitReleaseManager&version=0.6.0"
#tool "nuget:?package=GitVersion.CommandLine&version=3.6.5"
#tool "nuget:?package=coveralls.io&version=1.3.4"
#tool "nuget:?package=OpenCover&version=4.6.519"
#tool "nuget:?package=ReportGenerator&version=2.5.11"
#tool "nuget:?package=vswhere&version=2.1.4"

@ghuntley ghuntley added this to the 8.0.0 milestone Apr 4, 2018
@ghuntley ghuntley changed the title [WIP] househeeping: upgrade to cake 0.22.0 [WIP] househeeping: resolve broken CI infrastructure Apr 4, 2018
@ghuntley
Copy link
Member Author

ghuntley commented Apr 4, 2018

Blocked by cake-contrib/Cake.PinNuGetDependency#3

@ghuntley
Copy link
Member Author

Related issue @ NuGet/Home#5894

@ghuntley ghuntley closed this Apr 24, 2018
@ghuntley
Copy link
Member Author

Related issue at

@ghuntley ghuntley reopened this Apr 24, 2018
@ghuntley
Copy link
Member Author

ghuntley commented Apr 24, 2018

Amongst other things, we had to do some msbuild hacks for WPF. See related issue @ NuGet/Home#5894

@ghuntley ghuntley changed the title [WIP] househeeping: resolve broken CI infrastructure househeeping: resolve broken CI infrastructure Apr 24, 2018
@ghuntley ghuntley merged commit 634ea65 into develop Apr 24, 2018
@ghuntley ghuntley deleted the use-cake-22 branch April 24, 2018 05:47
@ghuntley ghuntley mentioned this pull request Apr 24, 2018
2 tasks
glennawatson pushed a commit that referenced this pull request Mar 23, 2019
 
househeeping: resolve broken CI infrastructure (#1587)
@lock lock bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants