-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Blazor ViewModelActivation #3871
Conversation
Going home. If build fails due to some other formatting, then I will deal with it later. Thanks for quick approval. |
@ChrisPulman Any idea when this will be pushed to nuget? |
We are working on replacing the signing certificate at the moment, as soon as this is resolved I will publish the relevant packages |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
@ChrisPulman Any approx estimate when that will be please? I am kind of copying everywhere the fixed implementation and it is making lot of mess I will have to cleanup later |
@tomasfil I been fighting with Microsoft to get the RxUI certificate done. sigh it takes a little while unfortunately. |
What kind of change does this PR introduce?
Bug fix. Current implementation did increase RefCount under ViewModelActivator once, but decrement it twice on deactivation. So the ViewModel was bricked if it was used as Scoped, or Singleton and would never activate again.
What is the current behavior?
Fixed behavior
What is the new behavior?
What might this PR break?
Should only fix
Please check if the PR fulfills these requirements
Other information: