Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Blazor ViewModelActivation #3871

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Fix Blazor ViewModelActivation #3871

merged 6 commits into from
Aug 2, 2024

Conversation

tomasfil
Copy link
Contributor

@tomasfil tomasfil commented Aug 2, 2024

What kind of change does this PR introduce?

Bug fix. Current implementation did increase RefCount under ViewModelActivator once, but decrement it twice on deactivation. So the ViewModel was bricked if it was used as Scoped, or Singleton and would never activate again.

What is the current behavior?

Fixed behavior

What is the new behavior?

What might this PR break?
Should only fix

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@tomasfil
Copy link
Contributor Author

tomasfil commented Aug 2, 2024

Going home. If build fails due to some other formatting, then I will deal with it later.

Thanks for quick approval.

@tomasfil tomasfil merged commit 8729191 into main Aug 2, 2024
1 check passed
@tomasfil tomasfil deleted the FixViewModelActivation branch August 2, 2024 16:19
@tomasfil
Copy link
Contributor Author

tomasfil commented Aug 4, 2024

@ChrisPulman Any idea when this will be pushed to nuget?
Thanks

@ChrisPulman
Copy link
Member

We are working on replacing the signing certificate at the moment, as soon as this is resolved I will publish the relevant packages

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2024
@tomasfil
Copy link
Contributor Author

@ChrisPulman Any approx estimate when that will be please? I am kind of copying everywhere the fixed implementation and it is making lot of mess I will have to cleanup later

@glennawatson
Copy link
Contributor

@tomasfil I been fighting with Microsoft to get the RxUI certificate done. sigh it takes a little while unfortunately.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants