feat: fix existing query values bug

reactiveui · Jun 25, 2024 · c8a3fcf · c8a3fcf
1 parent 9435295
commit c8a3fcf
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 12 deletions.
diff --git a/Refit.Tests/RequestBuilder.cs b/Refit.Tests/RequestBuilder.cs
@@ -2531,7 +2531,7 @@ public void ParametersShouldBePutAsExplicitQueryString()
 
             var uri = new Uri(new Uri("http://api"), output.RequestUri);
 
-            Assert.Equal("/query?q2=value2&q1=value1", uri.PathAndQuery);
+            Assert.Equal("/query?q1=value1&q2=value2", uri.PathAndQuery);
         }
 
         [Fact]

diff --git a/Refit/RequestBuilderImplementation.cs b/Refit/RequestBuilderImplementation.cs
@@ -980,17 +980,7 @@ param as IDictionary<string, string>
                 // UriBuilder business so that we preserve any hardcoded query
                 // parameters as well as add the parameterized ones.
                 var uri = new UriBuilder(new Uri(new Uri("http://api"), urlTarget));
-                var query = HttpUtility.ParseQueryString(uri.Query ?? "");
-                foreach (var key in query.AllKeys)
-                {
-                    if (!string.IsNullOrWhiteSpace(key))
-                    {
-                        queryParamsToAdd.Insert(
-                            0,
-                            new KeyValuePair<string, string?>(key, query[key])
-                        );
-                    }
-                }
+                ParseExistingQueryString(uri, queryParamsToAdd);
 
                 if (queryParamsToAdd.Count != 0)
                 {
@@ -1100,6 +1090,25 @@ var value in ParseEnumerableQueryParameterValue(
             }
         }
 
+        static void ParseExistingQueryString(UriBuilder uri, List<KeyValuePair<string, string?>> queryParamsToAdd)
+        {
+            if (string.IsNullOrEmpty(uri.Query))
+                return;
+
+            var query = HttpUtility.ParseQueryString(uri.Query);
+            var index = 0;
+            foreach (var key in query.AllKeys)
+            {
+                if (!string.IsNullOrWhiteSpace(key))
+                {
+                    queryParamsToAdd.Insert(
+                        index++,
+                        new KeyValuePair<string, string?>(key, query[key])
+                    );
+                }
+            }
+        }
+
         static string CreateQueryString(List<KeyValuePair<string, string?>> queryParamsToAdd)
         {
             // Suppress warning as ValueStringBuilder.ToString calls Dispose()
-Original file line number
+Diff line change
@@ Expand Up / @@ -2531,7 +2531,7 @@ public void ParametersShouldBePutAsExplicitQueryString() @@
                 var uri = new Uri(new Uri("http://api"), output.RequestUri);
-                Assert.Equal("/query?q2=value2&q1=value1", uri.PathAndQuery);
+                Assert.Equal("/query?q1=value1&q2=value2", uri.PathAndQuery);
             }
             [Fact]
@@ Expand Down @@