Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ApiResponse to correct previous adjustment #1711

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update

What is the current behavior?

The ApiResponse was adjusted but the implementation was misunderstood

What is the new behavior?

The ApiResponse has been updated, a Live test is required for this with a net 8.0 target due to the nature of operation.

What might this PR break?

None

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@ChrisPulman ChrisPulman merged commit 49cc592 into main Jun 9, 2024
1 check passed
@ChrisPulman ChrisPulman deleted the CP_UpdateApiResponse branch June 9, 2024 15:45
@sguryev
Copy link
Contributor

sguryev commented Jun 15, 2024

@ChrisPulman thank you for this update. Sorry I had no time to come back earlier :(

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants