Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Common Parameter Name used in Generated code #1735

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

closes #1724

What is the current behavior?

ex is used within the generated code, this is a common name

What is the new behavior?

Updated ex to be refit_ex to minimise the likelihood that there will be conflict.

What might this PR break?

None expected due to new name

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Common parameter name used in generated code
@TimothyMakkison
Copy link
Contributor

Would ______refit_ex or ______ex be better here? Similar to how the variables and properties are handled.

@ChrisPulman
Copy link
Member Author

Would ______refit_ex or ______ex be better here? Similar to how the variables and properties are handled.

Yes, that's a fair point, I am happy with that, I will update to ______ex later.
I was thinking along the lines of having refit in the name of the generated code would be more of an identification of source. But will stick with the previous trend until now.

@ChrisPulman ChrisPulman marked this pull request as draft June 25, 2024 15:15
@ChrisPulman ChrisPulman marked this pull request as ready for review June 25, 2024 19:02
@ChrisPulman ChrisPulman merged commit 9605c24 into main Jun 26, 2024
1 check passed
@ChrisPulman ChrisPulman deleted the FixForCommonParamaterName1724 branch June 26, 2024 19:54
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Parameter named ex causes compile error
2 participants