Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate code for derived non refit methods. #1875

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Oct 10, 2024

Fixes #1801

  • Raise diagnostics and create empty methods for derived non refit methods.
  • Incomplete as this comment needs to be addressed.

@ChrisPulman do you have any guidance here? Is this PR blocking you from the next release.

@TimothyMakkison
Copy link
Contributor Author

TimothyMakkison commented Oct 20, 2024

Thanks again. Do you have any issues you'd like me to look at before the release ie #1878?

  • Generate exception for derived non refit methods
  • Updated snapshot tests and incremental tests
  • Updated InheritedInterfaceWithoutRefitInBaseMethodsTest
  • Added InheritedInterfaceWithoutRefitMethodsOverrideBaseTest
  • Fixed typo in DictionaryDynamicQueryParametersTest

@TimothyMakkison TimothyMakkison marked this pull request as ready for review October 20, 2024 10:46
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.28%. Comparing base (6ebeda5) to head (213ef14).
Report is 142 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1875      +/-   ##
==========================================
- Coverage   87.73%   84.28%   -3.45%     
==========================================
  Files          33       36       +3     
  Lines        2348     2476     +128     
  Branches      294      347      +53     
==========================================
+ Hits         2060     2087      +27     
- Misses        208      310     +102     
+ Partials       80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman merged commit 56d7bcd into reactiveui:main Oct 22, 2024
2 of 3 checks passed
Copy link

github-actions bot commented Nov 6, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Refit interfaces do not implement base interface non refit methods
2 participants