React Router Support #407

gunnim · 2017-05-13T20:46:54Z

No description provided.

gunnim · 2017-05-13T20:49:22Z

Work is not fully complete but i decided to send the pull request so we could discuss here further.
What's missing are some unit tests, I'm extremely inexperienced in that regard so i'm having some problems implementing tests for methods that call static extension methods.
Was hoping you might have some suggestions on getting around that :)

…build

Daniel15 · 2017-05-14T07:21:41Z

Thanks, I'll take a look at this soon!

gunnim · 2017-06-06T00:19:55Z

Have you had a chance to take a look yet? Please let me know if I can do anything to help with the progress :)

Daniel15 · 2017-06-27T05:10:09Z

@gunnim - Sorry for the delay! The past month has been very busy for me 😢 nonetheless, reviewing this is still on my list of things to do. Thanks for your patience!

gunnim · 2017-06-27T09:17:43Z

Gotcha, glad to hear I'm on the list! :)

Daniel15

I'm so sorry for taking so long to review this!

Overall, this looks pretty good to me. I left a few comments inline.

Some of the files have very incorrect indentation (eg. lines indented by one space instead of one tab). Could you please fix those too?

Daniel15 · 2017-07-08T19:14:46Z

build.proj

@@ -10,8 +10,8 @@ of patent rights can be found in the PATENTS file in the same directory.
 <Project ToolsVersion="4.0" DefaultTargets="Build;Test;Package" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
 	<PropertyGroup>
 		<Major>3</Major>
-		<Minor>0</Minor>
-		<Build>1</Build>
+		<Minor>1</Minor>


Don't worry about bumping this, I'll bump it on release.

Daniel15 · 2017-07-08T19:16:19Z

build.proj

@@ -26,8 +26,9 @@ of patent rights can be found in the PATENTS file in the same directory.
 		<PackageAssemblies Include="React.Core" />
 		<PackageAssemblies Include="React.MSBuild" />
 		<PackageAssemblies Include="React.Owin" />
-		<PackageAssemblies Include="React.Web" />
-		<PackageAssemblies Include="React.Web.Mvc4" />
+    <PackageAssemblies Include="React.Router" />


Indentation looks a bit off here, maybe it's using spaces instead of tabs?

Whoops, i went over the .cs files and tabified but i missed this file and some xml. fixed

Daniel15 · 2017-07-08T19:16:48Z

src/React.Router/Content/Views/web.config.transform

+			</namespaces>
+		</pages>
+	</system.web.webPages.razor>
+</configuration>


I don't think this is needed.

The react router htmlhelper lives in this namespace. I seem to recall being unable to use it if I didn't either have this statement in my web.config or an explicit using statement in file.
You have a similar file in the mvc4 project.

Ah, interesting.

Daniel15 · 2017-07-08T19:21:32Z

src/React.Router/HtmlHelperExtensions.cs

+					);
+				}
+			}
+		}


You can probably just use ReactEnvironment.Current directly rather than wrapping it and rethrowing.

Sure, that particular block is copied from react.aspnet\htmlhelperextensions.cs.
I imagined you had a reason for doing it there that would also apply here?

In that case, I wanted to show a more specific error message for if ReactJS.NET was misconfigured. I guess that's useful here too though! Maybe ReactEnvironment should have a getter that does that (like ReactEnvironment.GetCurrentOrThrow()) so that the code is not duplicated.

Daniel15 · 2017-07-08T19:22:24Z

src/React.Router/HtmlHelperExtensions.cs

+			try
+			{
+				path = path ?? htmlHelper.ViewContext.HttpContext.Request.Path;
+				Response = Response ?? htmlHelper.ViewContext.HttpContext.Response;


Do you actually need the Response argument if it can come from the htmlHelper?

No, this was just intended as a convenience and i was hoping it might help for unit testing?

But I guess it might just be confusing, I'll remove it

Yeah i'm mocking the response obj in the unit tests, should I be doing this a different way?

i was hoping it might help for unit testing

For unit testing, you should be able to mock the ViewContext property on the IHtmlHelper.

Daniel15 · 2017-07-08T19:27:49Z

src/React.Router/ReactRouterException.cs

+
+namespace React.Router
+{
+	/// <summary>


Fix indentation in this file.

same as above, tabs on my end

Daniel15 · 2017-07-08T19:27:57Z

tests/React.Tests/Core/ReactEnvironmentTest.cs

+		[Fact]
+		public void CreatesIReactComponent()
+		{
+			var mocks = new Mocks();


Fix indentation in this file.

it's tabbed I swear haha!

Daniel15 · 2017-07-08T19:28:14Z

tests/React.Tests/Owin/EntryAssemblyFileSystemTests.cs

@@ -14,7 +14,7 @@ namespace React.Tests.Owin
 {
 	public class EntryAssemblyFileSystemTests
 	{
-        [Theory]
+		[Theory]


Please fix the indentation.

It's tabbed. I don't remember but i must have been fixing the indentation since the file shows as changed.

Sorry, looks good to me now, I guess there was a GitHub bug with rendering.

Daniel15 · 2017-07-08T19:28:23Z

tests/React.Tests/Router/HtmlHelperExtensionsTest.cs

+{
+	public class HtmlHelperExtensionsTest
+	{
+		/// <summary>


Please fix the indentation

Daniel15 · 2017-07-08T19:28:34Z

tests/React.Tests/Router/HtmlHelperExtensionsTest.cs

+		}
+
+		//[Fact]
+		//public void EngineIsReturnedToPoolAfterRender()


Remove this if you don't need it.

I was hoping for feedback from you on how to fix some of these tests.
I managed to fix
EngineIsReturnedToPoolAfterRender and
EnvironmentShouldGetCalledClientOnly myself but I think i need help with

ReactWithClientOnlyTrueShouldCallRenderHtmlWithTrue and
ReactWithServerOnlyTrueShouldCallRenderHtmlWithTrue
It's a static extension method calling another static extension method. Is there a way to proxy this behavior and have CreateRouterComponent create a Mocked reactcomponent?
Or should I let this and similar tests go?

Also please advise if you feel there should be more tests for some or any parts of this feature

It's a static extension method calling another static extension method. Is there a way to proxy this behavior and have CreateRouterComponent create a Mocked reactcomponent?

Hmm, that's tricky 😕 Static methods can't be mocked. Are you having issues with the test because of that?

Booya! Got all of my tests working :)

But my previous statement stands, this is not something I have good experience with so let me know if you think I need more.-.

Daniel15 · 2017-07-09T19:49:34Z

Sorry about the confusing comments around indentation! It looks okay to me now. I guess I was hitting a Github bug - All the code was hard along the left margin, with no indentation at all.

gunnim · 2017-07-09T21:07:21Z

Hehe no problem, and I did in fact leave some spaces.
Btw vstudio 2017 supports .editorconfig now and moving the file up one folder level set your defaults correctly for me.

Regarding the check failure, should i pull changes from this repo to fix the merge conflict?

gunnim · 2017-07-16T14:36:58Z

Noooo @Daniel15 !
I can't lose you now, we're so close ;D

dustinsoftware · 2017-07-22T16:50:46Z

Looking forward to trying this out - will build it locally and give it a go in one of our projects :)

Daniel15

Thanks! Let's get this in.

gunnim · 2017-07-22T17:40:18Z

Was actually doing exactly the same hehe, got it building but some unit tests are failing on Message: System.IO.FileLoadException : Could not load file or assembly 'JavaScriptEngineSwitcher.Core, Version=2.4.0.0, Culture=neutral, PublicKeyToken=c608b2a8cc9e4472' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)

I actually just finished pulling your 3.1.0 release building from source and I get the same error there

Daniel15 · 2017-07-22T18:12:48Z

Message: System.IO.FileLoadException : Could not load file or assembly 'JavaScriptEngineSwitcher.Core, Version=2.4.0.0, Culture=neutral, PublicKeyToken=c608b2a8cc9e4472' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference.

Try doing a clean build and see if that works. Usually this happens when you have an old assembly in the bin directory. "The located assembly's manifest definition does not match the assembly reference" uisually means that the version number in the bin directory differs from the version number that the app actually references.

It looks like the AppVeyor build is working: https://ci.appveyor.com/project/Daniel15/react-net/build/269

gunnim · 2017-07-22T18:17:35Z

So what did i did after trying to get the merge of branches working was...
I cloned 3.1.0 straight from this repo fresh, ran dev-build.bat, then build from vstudio on the tests and then ran them.... same error

gunnim · 2017-07-29T15:21:17Z

@Daniel15
This happens when you try to run the unit tests.
The issue seems to have to do with the fact that the v8 engine references javascriptengineswitcher.core v. 2.4.0 while the rest of the solution references 2.4.9
I also tried out upgrading all the js engine related packages but then the issue became that jspool was referencing v. 2.4.9 after i had upgraded to 2.4.10

This issue should be easily reproducible since I verified by doing a fresh clone of version 3.1.0.

Problem goes away if i manually specify a binding redirect.
ASP.NET projects are clever enough to automagically add a module binding redirect for the conflicting versions however.

Daniel15 · 2017-11-08T06:02:04Z

The build still seems to be working fine for me. Released this today as version 3.2. Sorry for the delay. Thanks!

gunnim added 7 commits May 7, 2017 13:43

Merge remote-tracking branch 'refs/remotes/reactjs/master'

4f32fa3

Merge remote-tracking branch 'refs/remotes/reactjs/master'

132180b

React.Router initial draft

ac7fd9e

spaces -> tabs

debe9b9

tests WIP

81beb7c

Unit tests and final cleanup

66cdcbd

Fix htmlhelper test and comment out environmentextensionsTest

57f07ed

gunnim added 2 commits May 13, 2017 22:31

Fix content include and only include aspnetcore files in netstandard …

c04716e

…build

new createComponent function added to environment interface

e6f570d

Daniel15 requested changes Jul 8, 2017

View reviewed changes

Various changes after feedback from Daniel.

c2514c4

Finished fixing all unit tests

6d14da0

Daniel15 approved these changes Jul 22, 2017

View reviewed changes

Merge branch 'master' into master

5a233ec

Daniel15 merged commit 5d1bd9d into reactjs:master Jul 22, 2017

React Router Support #407

React Router Support #407

Conversation

gunnim commented May 13, 2017

gunnim commented May 13, 2017

Daniel15 commented May 14, 2017

gunnim commented Jun 6, 2017

Daniel15 commented Jun 27, 2017

gunnim commented Jun 27, 2017

Daniel15 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gunnim Jul 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Daniel15 commented Jul 9, 2017

gunnim commented Jul 9, 2017

gunnim commented Jul 16, 2017

dustinsoftware commented Jul 22, 2017

Daniel15 left a comment

Choose a reason for hiding this comment

gunnim commented Jul 22, 2017

Daniel15 commented Jul 22, 2017

gunnim commented Jul 22, 2017

gunnim commented Jul 29, 2017

Daniel15 commented Nov 8, 2017

gunnim Jul 9, 2017 •

edited

Loading