Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a ability to select the default JavaScript engine #413

Merged
merged 2 commits into from
Jul 2, 2017
Merged

Added a ability to select the default JavaScript engine #413

merged 2 commits into from
Jul 2, 2017

Conversation

Taritsyn
Copy link
Contributor

This is not a classic pull request, but rather a proposal to improve the React.NET. This improvement will allow to meet the expectations of following users: dima117, dgpedro, luty81, malachib, ORuban, jyee117 and mattgross76.

@Daniel15
Copy link
Member

Daniel15 commented Jun 5, 2017

This seems reasonable. Could you please add a unit test for this too?

@Taritsyn
Copy link
Contributor Author

Taritsyn commented Jun 5, 2017

Added a unit tests.

@Daniel15
Copy link
Member

Daniel15 commented Jul 2, 2017

Thank you!

@Daniel15 Daniel15 added this to the 3.1 milestone Jul 2, 2017
@Daniel15
Copy link
Member

Daniel15 commented Jul 2, 2017

This is included in the 3.1 release: https://reactjs.net/2017/07/3.1.0-release.html. Thanks for your contribution, Andrey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants