Upgrade to JSPool 3.0 #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
commented
Jul 2, 2017
| { | ||
| // This could be called from ReactEnvironment.Dispose if that class is disposed after | ||
| // this class. Let's just ignore this if it's disposed. | ||
| if (!_disposed) | ||
| { | ||
| _pool.ReturnEngineToPool(engine); | ||
| engine.Dispose(); |
There was a problem hiding this comment.
This is probably not needed... The call site could just call Dispose on the engine directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades ReactJS.NET to use JSPool 3.0, and updates all JavaScriptEngineSwitcher dependencies to their latest versions
Also adds an assembly redirect hack for MSBuild so that it can correctly load
JavaScriptEngineSwitcher.CorewhenJavaScriptEngineSwitcher.V8references an older version. Normally this would be done inWeb.configorapp.configas an assembly redirect, but that does not work in MSBuild. The only way to do it in MSBuild is to manually redirect the assembly.