Upgrade React.Router to ASP.NET Core 2.0 #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
commented
Nov 4, 2017
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Include="..\React.Router\*.cs" /> |
There was a problem hiding this comment.
I need to fix the indentation in this file.
|
LGTM. Would be cool to have a sample as well to show off how it is used...
I can put one together if you don't have time
…On Sat, Nov 4, 2017 at 14:39, Daniel Lo Nigro ***@***.***> wrote:
Upgrades React.Router to ASP.NET 2.0.
Also splits ASP.NET MVC 4 support out into a separate React.Router.Mvc4
project. This is required as you can use both ASP.NET Core and "classic"
ASP.NET from .NET Framework, so simply discriminating based on framework
version is not sufficient, and it actually needs to be two separate
packages.
cc @dustinsoftware <https://github.com/dustinsoftware>
------------------------------
You can view, comment on, or merge this pull request online at:
#461
Commit Summary
- Upgrade React.Router to ASP.NET Core 2.0
File Changes
- *M* build.proj
<https://github.com/reactjs/React.NET/pull/461/files#diff-0> (1)
- *A* src/React.Router.Mvc4/React.Router.Mvc4.csproj
<https://github.com/reactjs/React.NET/pull/461/files#diff-1> (47)
- *M* src/React.Router/HtmlHelperExtensions.cs
<https://github.com/reactjs/React.NET/pull/461/files#diff-2> (7)
- *M* src/React.Router/React.Router.csproj
<https://github.com/reactjs/React.NET/pull/461/files#diff-3> (18)
- *M* src/React.Router/ReactRouterComponent.cs
<https://github.com/reactjs/React.NET/pull/461/files#diff-4> (4)
- *M* src/React.Router/ReactRouterException.cs
<https://github.com/reactjs/React.NET/pull/461/files#diff-5> (6)
- *M* src/React.Router/SetServerResponse.cs
<https://github.com/reactjs/React.NET/pull/461/files#diff-6> (6)
- *M* src/React.sln
<https://github.com/reactjs/React.NET/pull/461/files#diff-7> (7)
- *M* tests/React.Tests/React.Tests.csproj
<https://github.com/reactjs/React.NET/pull/461/files#diff-8> (2)
Patch Links:
- https://github.com/reactjs/React.NET/pull/461.patch
- https://github.com/reactjs/React.NET/pull/461.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#461>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5hFicrFlkkCNfxVGSvIoj4TgXjFJSzks5szNmfgaJpZM4QSK2d>
.
|
|
Unfortunately I don't have time to put a sample together :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
React.Routerto ASP.NET 2.0.Also splits ASP.NET MVC 4 support out into a separate
React.Router.Mvc4project. This is required as you can use both ASP.NET Core and "classic" ASP.NET from .NET Framework, so simply discriminating based on framework version is not sufficient, and it actually needs to be two separate packages.cc @dustinsoftware