Add optional error boundary support #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinsoftware
force-pushed
the
error-boundaries
branch
2 times, most recently
from
b656cc0
to
bd1badb
Compare
|
Ok @Daniel15 this is ready for review |
|
@Daniel15 would you have time to take a look at this PR soon? Are you OK with the overall direction? |
Daniel15
reviewed
Dec 11, 2017
src/React.Core/ReactComponent.cs
Outdated
| { | ||
| attributes += string.Format(" class=\"{0}\"", ContainerClass); | ||
| if (_configuration.ExceptionHandler == null) { |
There was a problem hiding this comment.
I wonder if we should also allow setting an exception handler per component (eg. as an argument to this method). Hmm.
src/React.Core/ReactComponent.cs
Outdated
| { | ||
| attributes += string.Format(" class=\"{0}\"", ContainerClass); | ||
| if (_configuration.ExceptionHandler == null) { |
There was a problem hiding this comment.
Instead of checking if this is null, what about making it the default handler? That way, _configuration.ExceptionHandler would never be null.
src/React.Core/ReactComponent.cs
Outdated
| ContainerId | ||
| )); | ||
| } | ||
| _configuration.ExceptionHandler(ex); |
There was a problem hiding this comment.
Might be worth passing ComponentName and ContainerId too.
|
Thanks for the review, I'll push an update soon :) |
dustinsoftware
force-pushed
the
error-boundaries
branch
2 times, most recently
from
b2c4997
to
4ef3074
Compare
dustinsoftware
force-pushed
the
error-boundaries
branch
from
4ef3074
to
46b45b3
Compare
dustinsoftware
force-pushed
the
error-boundaries
branch
from
a6ceeab
to
13c9926
Compare
|
@Daniel15 this should be good to go, want to give it another look? |
Daniel15
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated a sample so you can see how this works. When specifying an error handler, then errors will be caught during server-render (including those not handled by error boundaries).
Some tests still need to be added, but I wanted to get the discussion started about this approach.