Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for script nonce attributes #496

Merged
merged 4 commits into from
Feb 19, 2018

Conversation

dustinsoftware
Copy link
Member

@dustinsoftware dustinsoftware commented Jan 13, 2018

Fixes #430, #482, #334

@dustinsoftware
Copy link
Member Author

dustinsoftware commented Jan 21, 2018

@Daniel15 this is good to go, but I'd like another set of eyes to give it a quick look before it gets merged 😄

@dustinsoftware
Copy link
Member Author

Merging this so it doesn't get stale, let me know if needs modification before shipping. Tested on Mvc4 and CoreMvc.

@dustinsoftware dustinsoftware merged commit 5f5f65d into reactjs:master Feb 19, 2018
Copy link
Member

@Daniel15 Daniel15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Sorry I never got to this, I think you sent it while I was on vacation.

/// <summary>
/// Gets the site-wide configuration.
/// </summary>
IReactSiteConfiguration Configuration { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there already a getter for this? ReactSiteConfiguration.Configuration or .Current or something like that?

@dustinsoftware
Copy link
Member Author

dustinsoftware commented Mar 5, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants