Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component name valid caching #529

Merged
merged 2 commits into from
Apr 8, 2018
Merged

Component name valid caching #529

merged 2 commits into from
Apr 8, 2018

Conversation

DaniilSokolyuk
Copy link
Contributor

Component name valid caching

Daniel15
Daniel15 approved these changes Apr 8, 2018
View reviewed changes
Copy link
Member

@Daniel15 Daniel15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me. The only concern I have is that static fields often make unit testing more difficult, as it's tricky to reset the field values. That's likely not really an issue in this particular case, though.

@Daniel15 Daniel15 merged commit 943baec into reactjs:master Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel15 Daniel15 Daniel15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DaniilSokolyuk @Daniel15