Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extracting state logic into a reducer (100% finished) #100

Merged
merged 35 commits into from
Aug 12, 2024
Merged

Extracting state logic into a reducer (100% finished) #100

merged 35 commits into from
Aug 12, 2024

Conversation

habibium
Copy link
Contributor

No description provided.

@habibium habibium changed the title Extracting state logic into a reducer Extracting state logic into a reducer (0% finished) Oct 29, 2023
@github-actions
Copy link

github-actions bot commented Oct 29, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 80.48 KB (🟡 +44 B) 184.38 KB
/500 80.47 KB (🟡 +44 B) 184.37 KB
/[[...markdownPath]] 82.25 KB (🟡 +44 B) 186.16 KB
/errors 80.66 KB (🟡 +44 B) 184.56 KB
/errors/[errorCode] 80.63 KB (🟡 +44 B) 184.53 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@habibium
feat: ✨ Finished 6%
2b96ef2 
Translated:
  - Consolidate state logic with a reducer overview
  - 3 steps
@habibium habibium changed the title Extracting state logic into a reducer (0% finished) Extracting state logic into a reducer (6% finished) Nov 3, 2023
@habibium
feat: ✨ Finished 14%
dcc87cf 
- Translated half of Step 1
@habibium
feat: ✨ Finished 17%
4580fc6 
Translated:
  - A paragraph from step 1
@habibium
feat: ✨ Finished 24%
6c5db97 
Translated:
  - paragraph step 1
@habibium habibium changed the title Extracting state logic into a reducer (6% finished) Extracting state logic into a reducer (24% finished) Nov 14, 2023
@habibium
feat: ✨ Finished 27%
a430723 
Translated:
  - step 1 full
@habibium habibium changed the title Extracting state logic into a reducer (24% finished) Extracting state logic into a reducer (27% finished) Jan 13, 2024
@habibium habibium changed the title Extracting state logic into a reducer (27% finished) Extracting state logic into a reducer (48% finished) Jan 14, 2024
@habibium
feat: ✨ Finished 54%
2287825 
- translated step 2 full
@habibium habibium changed the title Extracting state logic into a reducer (48% finished) Extracting state logic into a reducer (54% finished) Jan 16, 2024
@habibium
feat: ✨ Translated 85%
33999e6 
Signed-off-by: HabibMollah <habib.prodev@gmail.com>
@habibium
feat: ✨ Translate challenge 1 of 4
46550d3
@habibium
feat: ✨ Translate challenge 2 of 4 (partial)
a38349c
@habibium
feat: ✨ Translate challenge 2 of 4 (partial)
49e88b0
@habibium
feat: ✨ Translated Challenge 2 of 4 (partial)
f1510dd 
Signed-off-by: HabibMollah <habib.prodev@gmail.com>
@habibium
feat: ✨ Translated Challenge 2 of 4
7a25576
@habibium
feat: ✨ Translate Challenge 3 of 4 (1st paragraph)
53b068f
@habibium
feat: ✨ Translate Challenge 3 of 4 (2nd paragraph)
702ead0
@habibium
feat: ✨ Translate Challenge 3 of 4 (3rd paragraph)
c272431
@habibium
feat: ✨ Translate Challenge 3 of 4 (hint)
1d0d10e
@habibium
feat: ✨ Translate Challenge 3 of 4
5008d6c
@habibium
feat: ✨ Translate Challenge 4 of 4 (question)
b71edb6
@habibium
feat: ✨ Translate Challenge 4 of 4 (hint)
ab74ab4
@habibium
feat: ✨ Translate 100% (Challenge 4 of 4)
31f7592
@habibium
fix: ✨ update colons
826fb5c
@habibium
feat: ✨ Translate Challenge component
c0f49e3
@habibium
feat: ✨ Translate Challenges component
86fa226
@habibium habibium changed the title Extracting state logic into a reducer (72% finished) Extracting state logic into a reducer (100% finished) Jul 16, 2024
@habibium habibium marked this pull request as ready for review July 16, 2024 14:18
@habibium
Copy link
Contributor Author

পেজ পুরোটা অনুবাদ শেষ হলো

@habibium habibium marked this pull request as draft August 1, 2024 20:32
@habibium habibium marked this pull request as ready for review August 1, 2024 20:32
@habibium
Copy link
Contributor Author

habibium commented Aug 8, 2024

@nafistiham @moshfiqrony bhai, awaiting your review. Check it out when you get some free time 😊.
I have plans to start working on another page from the next week, It would be awesome if this gets merged before that.

@moshfiqrony
Copy link
Collaborator

@nafistiham @moshfiqrony bhai, awaiting your review. Check it out when you get some free time 😊. I have plans to start working on another page from the next week, It would be awesome if this gets merged before that.

on it

moshfiqrony
moshfiqrony approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@moshfiqrony moshfiqrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moshfiqrony moshfiqrony added this pull request to the merge queue Aug 12, 2024
Merged via the queue into reactjs:main with commit 9f7c73c Aug 12, 2024
2 of 3 checks passed
@moshfiqrony moshfiqrony mentioned this pull request Aug 12, 2024
Open
@habibium habibium deleted the extracting-state-logic-into-a-reducer branch August 13, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshfiqrony moshfiqrony moshfiqrony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@habibium @moshfiqrony