Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of React Developer Tools Page #11

Merged
merged 4 commits into from
May 2, 2023

Conversation

nomandhoni-cs
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@moshfiqrony
Copy link
Collaborator

Can we start it as a draft so that no one mistakenly merge it. I know you added WIP. But it would be nice.

@nomandhoni-cs nomandhoni-cs marked this pull request as draft May 1, 2023 13:35
@nomandhoni-cs
Copy link
Collaborator Author

Can we start it as a draft so that no one mistakenly merge it. I know you added WIP. But it would be nice.

I was waiting for the CI CD to pass

@nomandhoni-cs nomandhoni-cs changed the title [WIP] Translation of React Developer Tools Page Translation of React Developer Tools Page May 1, 2023
@nomandhoni-cs nomandhoni-cs marked this pull request as ready for review May 1, 2023 15:57
Copy link
Contributor

@KhanShaheb34 KhanShaheb34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be made in my opinion.

cc: @moshfiqrony @nafistiham

src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved

> Try reloading the app if developer tools doesn't connect after a few seconds.
> যদি ডেভেলপার টুলসটি আপনার অ্যাপ এর সাথে কয়েক সেকেন্ডের মধ্যে কানেক্ট না হলে আপনার অ্যাপ টি Reload করুন।
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

যদি ডেভেলপার টুলসটি আপনার অ্যাপ এর সাথে কয়েক সেকেন্ডের মধ্যে কানেক্ট না হলে আপনার অ্যাপ টি Reload করুন।

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion would be replacing কানেক্ট with যুক্ত
Here connect is not a really tech word I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nafistiham Bhai, In our daily life we use কানেক্ট word more than যুক্ত word (Almost always). So I think we can more relate with কানেক্ট

Copy link
Member

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some translations that I think should be changed. Feel free to add any additional feedbacks.

cc @moshfiqrony @nafistiham

src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
src/content/learn/react-developer-tools.md Outdated Show resolved Hide resolved
@nafistiham
Copy link
Collaborator

I concur mostly with @KhanShaheb34 Added another suggestion from my side.

Copy link
Collaborator

@moshfiqrony moshfiqrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's wait one more maintainer to approve.

@moshfiqrony
Copy link
Collaborator

@shakib609 @nafistiham requesting one more approval from you guys. We are almost near to complete our first page with a great effort by @nomandhoni-cs bhai.

Copy link
Member

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work @nomandhoni-cs 🙌

@moshfiqrony moshfiqrony added this pull request to the merge queue May 2, 2023
Merged via the queue into reactjs:main with commit 886f99b May 2, 2023
@nomandhoni-cs nomandhoni-cs deleted the react-developer-tools-page branch May 2, 2023 08:11
@clevermiraz
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants