Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate render and commit page #12

Merged
merged 5 commits into from
May 2, 2023

Conversation

MahdiMurshed
Copy link
Contributor

No description provided.

@MahdiMurshed MahdiMurshed changed the title translate: intro translate: intro of render and commit page May 1, 2023
@MahdiMurshed MahdiMurshed marked this pull request as ready for review May 1, 2023 18:41
@MahdiMurshed MahdiMurshed changed the title translate: intro of render and commit page Translate render and commit page May 1, 2023
@ahnafyy
Copy link
Collaborator

ahnafyy commented May 1, 2023

Great work @MahdiMurshed one of the maintainers will get this reviewed as soon as possible (I can if no one gets to it first) and we can get this merged soon! 💯 🏆 🥇

Copy link
Member

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor issues @MahdiMurshed .

src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 2, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@moshfiqrony moshfiqrony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great effort @MahdiMurshed Let's wait for one more contributor's approval to merge it.

Copy link
Collaborator

@nomandhoni-cs nomandhoni-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate your effort.
Everything looks good to me!
But next time please try to use easy words উদ্ভূত => সৃষ্ট , দুবার => দুই বার

@MahdiMurshed
Copy link
Contributor Author

I really appreciate your effort. Everything looks good to me! But next time please try to use easy words উদ্ভূত => সৃষ্ট , দুবার => দুই বার

okay bhai

@moshfiqrony moshfiqrony enabled auto-merge May 2, 2023 14:50
@moshfiqrony moshfiqrony added this pull request to the merge queue May 2, 2023
Merged via the queue into reactjs:main with commit 99832ee May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants