Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referencing values with refs #25

Merged
merged 11 commits into from
May 19, 2023

Conversation

nafistiham
Copy link
Collaborator

This PR might be broken into other parts if the page is too long!

@github-actions
Copy link

github-actions bot commented May 17, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 93.63 KB (-2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.4 KB (🟡 +173 B) 170.03 KB
/500 76.4 KB (🟡 +173 B) 170.02 KB
/[[...markdownPath]] 77.82 KB (🟡 +173 B) 171.45 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@nafistiham
Copy link
Collaborator Author

So, I have decided to make some buttons in Bangla. Maybe there could be more changes, but I only limited the translation to what the page needed for the time being. As far as I have seen, making the whole page Bangla could look really nice. So, that is going to be a thing to decide. Like 'download', 'fork'...everything. Again the PR has gone a bit large. So, take your time and make change requests as much as you can.
@moshfiqrony @nomandhoni-cs

@moshfiqrony
Copy link
Collaborator

Thanks @nafistiham bhai. Reviews will be done by tomorrow early evening.

Copy link
Collaborator

@nomandhoni-cs nomandhoni-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nafistiham ভাই অনেক ধন্যবাদ, আপনার ট্রান্সলেশন বরাবরের মতোই অসাধারন।

src/content/learn/referencing-values-with-refs.md Outdated Show resolved Hide resolved
@nafistiham
Copy link
Collaborator Author

@moshfiqrony vai. Thanks. Fixed the PR with your help!

@nafistiham nafistiham added this pull request to the merge queue May 19, 2023
Merged via the queue into reactjs:main with commit 1b21548 May 19, 2023
@nafistiham nafistiham deleted the referencing-values-with-refs branch May 19, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants