Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for community link #27

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

moshfiqrony
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented May 18, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vai, I think you wanted to put the server link maybe?

@@ -4,6 +4,9 @@ This repo contains the source code and documentation powering [bn.react.dev](htt

## Getting started

### Join the Bengali discord community
Hi dev, We are Bengali React doc translation community welcome you to join the discord server - https://github.com/reactjs/bn.react.dev/issues/26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have been the server link?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bhai I try to keep the issue as the main point for community link and update. That's why I added the issue intentionally. Like for progress we follow one issues.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! now I got it. I guess in that case we could make the code inline and a bit paraphrase like this?

Hi dev, we are Bengali React doc translation community. We welcome you to join our discord server.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'd suggest making the line in the issue inline as well. Like...
Anyway, approving the PR.

Here is the discord server invitation link.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh! I thought approving wouldn't just merge it immediately. I am so sorry.

@moshfiqrony moshfiqrony added this pull request to the merge queue May 18, 2023
Merged via the queue into reactjs:main with commit 3f1a020 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants