Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new project page #3

Merged
merged 11 commits into from
May 15, 2023

Conversation

moshfiqrony
Copy link
Collaborator

@moshfiqrony moshfiqrony commented Apr 30, 2023

@github-actions
Copy link

github-actions bot commented Apr 30, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.23 KB (🟡 +73 B) 169.86 KB
/500 76.23 KB (🟡 +73 B) 169.85 KB
/[[...markdownPath]] 77.65 KB (🟡 +73 B) 171.28 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@moshfiqrony
Copy link
Collaborator Author

Previous reviews

@moshfiqrony moshfiqrony changed the title [WIP] Start a new project page Start a new project page May 2, 2023
@moshfiqrony moshfiqrony marked this pull request as ready for review May 2, 2023 15:24
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of them are suggestions.

src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
src/content/learn/start-a-new-react-project.md Outdated Show resolved Hide resolved
@sowrovsarkar63
Copy link
Contributor

I translated a full section. But I'm facing a server error to run the specific route in the local environment
Screenshot_1

@MahdiMurshed
Copy link
Contributor

I translated a full section. But I'm facing a server error to run the specific route in the local environment Screenshot_1

@sowrovsarkar63 what is the name of your branch? Can you create a PR with that branch and mention the problem there?

@moshfiqrony
Copy link
Collaborator Author

All the reviews are incorporated. Just need your approval @nafistiham @nomandhoni-cs @shakib609

Copy link
Member

@shakib609 shakib609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @moshfiqrony bhai. 🚀

Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@nafistiham nafistiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@moshfiqrony moshfiqrony added this pull request to the merge queue May 15, 2023
Merged via the queue into reactjs:main with commit 02fb9b5 May 15, 2023
@moshfiqrony moshfiqrony deleted the start-a-new-project-page branch May 15, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants